gh-146011: Fix use-after-free in signaldict_repr after deletion#153784
Open
brijkapadia wants to merge 3 commits into
Open
gh-146011: Fix use-after-free in signaldict_repr after deletion#153784brijkapadia wants to merge 3 commits into
signaldict_repr after deletion#153784brijkapadia wants to merge 3 commits into
Conversation
Contributor
Author
|
@skirpichev could you take a look whenever you have time? |
skirpichev
self-requested a review
July 19, 2026 08:40
skirpichev
reviewed
Jul 19, 2026
Comment on lines
+1505
to
+1506
| if (traps != NULL) { | ||
| traps->flags = NULL; |
Member
There was a problem hiding this comment.
This will introduce a memory leak, if context was not deleted before. You miss DECREF in this case, no?
I think that my suggestion in the issue thread is more correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.